You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm-watch is not used by the project (and would be a dev dependency if it were), so this PR removes it to address vulunerabilties down the line to @capacitor/assets (ionic-team/capacitor-assets#590)
The reason will be displayed to describe this comment to others. Learn more.
Agree that npm-watch is unused, just wondering if we should also npm i as part of this PR to also clean up the package-lock.json at the root of this mono-repo.
Hey @kensodemann , I've updated the package-lock.json after a rebase with the hope that the open source gods will merge this PR to resolve downstream security vulnerabilities.
Hey @kensodemann , I've updated the package-lock.json after a rebase with the hope that the open source gods will merge this PR to resolve downstream security vulnerabilities.
So are you saying that the package-lock.json file is part of an existing change on main then that I cannot see here?
Hey @kensodemann , I've updated the package-lock.json after a rebase with the hope that the open source gods will merge this PR to resolve downstream security vulnerabilities.
So are you saying that the package-lock.json file is part of an existing change on main then that I cannot see here?
Weird, the commit showed up a lot longer than the comment. The update to package-lock.json is showing now
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm-watchis not used by the project (and would be a dev dependency if it were), so this PR removes it to address vulunerabilties down the line to @capacitor/assets (ionic-team/capacitor-assets#590)