Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mock-doc): don't show error message for SSR workflows #6075

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

christian-bromann
Copy link
Member

What is the current behavior?

An error message is shown when user render a component using element internals via SSR.

GitHub Issue Number: fixes #6073

What is the new behavior?

Error message is only shown when using Stencil testrunner.

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

There hasn't been any tests for this error message in the first place and creating one would be too much effort for the value it provides.

Other information

n/a

@christian-bromann christian-bromann merged commit 84a3607 into main Dec 11, 2024
88 checks passed
@christian-bromann christian-bromann deleted the cb/element-internals-message branch December 11, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Misleading console.error when rendering components using internals SSR
2 participants