fix(runtime): ensure Node is defined #6061
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Stencils runtime tries to access
Node
which may not be defined when server side rendering components.What is the new behavior?
Have a check for
Node
before accessing it.fixes ionic-team/stencil-ds-output-targets#537
Documentation
Does this introduce a breaking change?
Testing
We will have to put some tests in place to ensure we can build the Output targets project. This should be a separate effort.
Other information
n/a