feat(runtime): make shadow root adopt scoped component styles #6028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This was released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Currently, when a scoped component is inside a shadow root, the component styles are added to a
<style>tag.GitHub Issue Number: #6027
What is the new behavior?
If adopting stylesheets is supported then the scoped component styles are added to the shadow root's adopted stylesheets. The current behavior (adding styles to a
<style>tag) remains as a fallback.Does this introduce a breaking change?
Testing
Manual testing. I couldn't find relevant unit tests, and recently merged changes were also without unit tests, so I assume they are not yet in place for this file/feature.