Commits on Apr 5, 2024

1. feat(compiler): perform automatic key insertion in more situations …

   This expands the scope of the automatic key insertion feature that was
   added in #5143. Previously the feature stopped at the border of any
   `JsxExpression` syntax node (a bit of arbitrary JavaScript wrapped in
   curly braces and then inserted into JSX) so that if you were doing
   something like:
   
   ```tsx
   <div>{ someCondition && <span>when condition is true</span>}</div>
   ```
   
   the compiler would insert a key into the `<div>` syntax tree node but
   _not_ the node for the `<span>`. We did this to just be a bit cautious
   with the feature because there are a lot of different things that could
   be going on within a `JsxExpression` node, and some things which could
   be written within curly braces which would not be safe to transform,
   such as the following:
   
   ```tsx
   <div>{ xs.map(x => <span>{ x }</span>) }</div>
   ```
   
   We wouldn't want to insert a key into the `<span>` syntax tree node
   because that would result in the dynamically generated `<span>` tags
   always having the same key attributes.
   
   That said, there are some situations where it is safe to insert a key,
   such as the `condition || <some-tag />` case shown above. This change
   adds support for inserting keys in those situations.
   
   STENCIL-1120

   

   alicewriteswrongs committed Apr 5, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for f1b3faa
   • Browse repository at this point

   Copy the full SHA

   f1b3faa View commit details

   Browse the repository at this point in the history