Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): patch removeChild for scoped components #5148

Merged
merged 3 commits into from
Dec 12, 2023
Merged

fix(runtime): patch removeChild for scoped components #5148

merged 3 commits into from
Dec 12, 2023

Commits on Dec 8, 2023

  1. fix(runtime): add patch for removeChild on scoped components 

    This commit adds a patch for an HtmlElement's `removeChild` method

Fixes: #3278 #2259

STENCIL-937

Co-authored-by: johnjenkins <[email protected]>
    @tanner-reits @johnjenkins
    tanner-reits and johnjenkins committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    34bca0f View commit details
    Browse the repository at this point in the history

  2. add e2e tests

    @tanner-reits
    tanner-reits committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    0aba8c9 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. PR feedback 

    Co-authored-by: Ryan Waskiewicz <[email protected]>
    @tanner-reits @rwaskiewicz
    tanner-reits and rwaskiewicz authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    a356bfe View commit details
    Browse the repository at this point in the history