Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(task): consider config sys in task runner #3518

Merged
merged 1 commit into from
Aug 15, 2022

Commits on Aug 12, 2022

  1. fix(task): consider config sys in task runner

    this commit updates the generation of a `ValidatedConfig` entity to take
    a `sys` property on a user provided `Config` in the context of
    `runTask`.
    
    when generating the validated configuration, the `sys` entity takes
    precedence over all other configurations, with the belief that in the
    event argument was provided, it is the intent of the user to use it. in
    the event `sys` is not expressly provided, use the one on the provided
    configuration entity. this is useful in the case that a user used
    stencil's external facing apis in a flow that:
    1. loads a configuration
    2. validates that configuration
    3. uses that configuration when calling `runTask` directly
    
    this commit fixes a bug introduced making `sys` a required field on
    `ValidatedConfig`, where `config.sys` was not properly accounted for.
    the bug was initially introduced in
    a6a9171 (#3491)
    rwaskiewicz committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    7ef0bfd View commit details
    Browse the repository at this point in the history