-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: stencil test with e2e
trigger documentation build
#5950
Labels
Bug: Validated
This PR or Issue is verified to be a bug within Stencil
Comments
christian-bromann
added
Bug: Validated
This PR or Issue is verified to be a bug within Stencil
and removed
triage
labels
Aug 19, 2024
Thanks for reporting @Sukaato. I ingested the bug into our backlog but I want to set the expectations straight: we can't tell you when we will be able to tackle the issue. If you are blocked on it, we recommend to take a stab and provide a bug fix, the Stencil team is happy to provide guidance on that. Thanks! |
Sukaato
added a commit
to Sukaato/stencil
that referenced
this issue
Aug 19, 2024
Do not generate custom output target on test fixes: ionic-team#5950
2 tasks
Sukaato
added a commit
to Sukaato/stencil
that referenced
this issue
Aug 27, 2024
Do not generate custom output target on test fixes: ionic-team#5950
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 30, 2024
Do not generate custom output target on test fixes: #5950
A fix for this has been released in Stencil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Stencil Version
4.20.0
Current Behavior
When running
stencil test --e2e --spec
, stencil have to make a build for the e2e part, and this trigger generate the custom documentation, and generate the documentation should not be part of the testing phase.Expected Behavior
do not generate the custom documentation
System Info
Steps to Reproduce
npm test
hould be by default stencil test --e2e --spec)*Code Reproduction URL
https://github.com/Sukaato/stencil-test-generate-docs
Additional Information
Should add a condition here: https://github.com/ionic-team/stencil/blob/main/src/compiler/output-targets/output-custom.ts#L7
Since
outputCustom
can generate more that a readme documentation, i think the flagconfig.buildDocs
should be not used, maybe theconfig._isTesting
can be usedThe text was updated successfully, but these errors were encountered: