Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Broken exports for testing #5871

Closed
3 tasks done
Tallyb opened this issue Jun 28, 2024 · 1 comment · Fixed by #5873, #5878 or ionic-team/ionic-framework#29685
Closed
3 tasks done

bug: Broken exports for testing #5871

Tallyb opened this issue Jun 28, 2024 · 1 comment · Fixed by #5873, #5878 or ionic-team/ionic-framework#29685
Assignees
@christian-bromann
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@Tallyb
Copy link
Contributor

Tallyb commented Jun 28, 2024

Prerequisites

Stencil Version

4.19.0

Current Behavior

Using in jest config file the following:

preset: @stencil/core/testing
transform: @stencil/core/testing/jest-preprocessor

Worked ok until 4.18.2
currently getting error:

  Preset @stencil/core/testing not found.

  Configuration Documentation:
  https://jestjs.io/docs/configuration

Expected Behavior

work as before
quite likely as a result of this: a2fa93b
Partial fix was only for mockDoc imports. #5860

System Info

node 20. 
npm 10.7

Steps to Reproduce

build a simple jest config with preset @stencil/core/testing
Try to run jest.

Code Reproduction URL

n/a

Additional Information

No response
@ionitron-bot ionitron-bot bot added the triage label Jun 28, 2024
@christian-bromann christian-bromann self-assigned this Jun 28, 2024
@christian-bromann christian-bromann added Bug: Validated This PR or Issue is verified to be a bug within Stencil and removed triage labels Jun 28, 2024
@christian-bromann christian-bromann mentioned this issue Jun 28, 2024
Merged
2 tasks
@christian-bromann
Copy link
Member

@Tallyb thanks so much for reporting the bug and apologize for the regression. I have raised a PR with a bug fix. We were not aware that this was a use case for Stencil users. Moving on we have tests for this in place to ensure it won't break again.

@christian-bromann christian-bromann mentioned this issue Jul 2, 2024
Merged
@brandyscarney brandyscarney mentioned this issue Jul 2, 2024
Merged
github-merge-queue bot pushed a commit to ionic-team/ionic-framework that referenced this issue Jul 2, 2024
@brandyscarney
chore(deps): update dependency @stencil/core to v4.19.2 (#29685)
d70ea40 
Issue number: resolves #29681

---------

### Release Notes

<details>
<summary>ionic-team/stencil (@&#8203;stencil/core)</summary>

###
[`v4.19.2`](https://togithub.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4192-2024-07-02)

[Compare
Source](https://togithub.com/ionic-team/stencil/compare/v4.19.1...v4.19.2)

### Bug Fixes

* **hydrate:** partially revert
[#5838](ionic-team/stencil#5838)
([#5876](ionic-team/stencil#5876))
([dfbc340](ionic-team/stencil@dfbc340))
* **hydrate:** support server side rendering of components with listener
([#5877](ionic-team/stencil#5877))
([2c5b7f8](ionic-team/stencil@2c5b7f8)),
fixes [#5869](ionic-team/stencil#5869)
* **testing:** add testing sub module to export map
([#5873](ionic-team/stencil#5873))
([bb2e04f](ionic-team/stencil@bb2e04f)),
fixes [#5871](ionic-team/stencil#5871) and
[#5868](ionic-team/stencil#5868)

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christian-bromann christian-bromann

Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Milestone
No milestone
2 participants
@christian-bromann @Tallyb