Skip to content

Commit

Permalink
chore(ci): update workflows for merge queue (#4436)
Browse files Browse the repository at this point in the history
this commit updates all workflows whose status is reported to gate on
`main` to include the `merge_group` event trigger. the github
documentation[1] states:

> If your repository uses GitHub Actions to perform required checks on
> pull requests in your repository, you need to update the workflows
> to include the merge_group event as an additional trigger. Otherwise,
> status checks will not be triggered when you add a pull request to a
> merge queue. The merge will fail as the required status check will
> not be reported.

it's not abundantly clear if this is needed for reusable workflows
explicitly. `merge_group` is added in this commit to avoid the need to
configure this feature via multiple prs

[1]: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#triggering-merge-group-checks-with-github-actions
  • Loading branch information
rwaskiewicz authored May 31, 2023
1 parent bd1023a commit c98150b
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Build Stencil

on:
merge_group:
workflow_call:
# Make this a reusable workflow, no value needed
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/lint-and-format.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Lint and Format Stencil (Check)

on:
merge_group:
workflow_call:
# Make this a reusable workflow, no value needed
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: CI

on:
merge_group:
push:
branches:
- 'main'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-analysis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Analysis Tests

on:
merge_group:
workflow_call:
# Make this a reusable workflow, no value needed
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-browserstack.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: BrowserStack Tests

on:
merge_group:
pull_request_target:
branches:
- 'main'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-bundlers.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Bundler Tests

on:
merge_group:
workflow_call:
# Make this a reusable workflow, no value needed
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-component-starter.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Component Starter Smoke Test

on:
merge_group:
workflow_call:
# Make this a reusable workflow, no value needed
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: E2E Tests

on:
merge_group:
workflow_call:
# Make this a reusable workflow, no value needed
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-unit.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Unit Tests

on:
merge_group:
workflow_call:
# Make this a reusable workflow, no value needed
# https://docs.github.com/en/actions/using-workflows/reusing-workflows
Expand Down

0 comments on commit c98150b

Please sign in to comment.