fix(compiler): support rollup's external input option (#3227)

Pluck the external option from the stencil config and pass it through to rollup. Co-authored-by: Christian Bromann <[email protected]>
ionic-team · Jun 24, 2024 · 2c68849 · 2c68849
1 parent 13db920
commit 2c68849
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 1 deletion.
diff --git a/src/compiler/bundle/bundle-output.ts b/src/compiler/bundle/bundle-output.ts
@@ -151,6 +151,8 @@ export const getRollupOptions = (
     onwarn: createOnWarnFn(buildCtx.diagnostics),
 
     cache: compilerCtx.rollupCache.get(bundleOpts.id),
+
+    external: config.rollupConfig.inputOptions.external,
   };
 
   return rollupOptions;

diff --git a/src/compiler/config/test/validate-rollup-config.spec.ts b/src/compiler/config/test/validate-rollup-config.spec.ts
@@ -56,6 +56,7 @@ describe('validateStats', () => {
     config.rollupConfig = {
       inputOptions: {
         context: 'window',
+        external: 'external_symbol',
         notAnOption: {},
       },
       outputOptions: {
@@ -69,6 +70,7 @@ describe('validateStats', () => {
     expect(rollupConfig).toEqual({
       inputOptions: {
         context: 'window',
+        external: 'external_symbol',
       },
       outputOptions: {
         globals: {

diff --git a/src/compiler/config/validate-rollup-config.ts b/src/compiler/config/validate-rollup-config.ts
@@ -26,7 +26,7 @@ export const validateRollupConfig = (config: d.Config): d.RollupConfig => {
   if (rollupConfig.inputOptions && isObject(rollupConfig.inputOptions)) {
     cleanRollupConfig = {
       ...cleanRollupConfig,
-      inputOptions: pluck(rollupConfig.inputOptions, ['context', 'moduleContext', 'treeshake']),
+      inputOptions: pluck(rollupConfig.inputOptions, ['context', 'moduleContext', 'treeshake', 'external']),
     };
   }
 

diff --git a/src/declarations/stencil-public-compiler.ts b/src/declarations/stencil-public-compiler.ts
@@ -1749,6 +1749,11 @@ export interface RollupInputOptions {
   context?: string;
   moduleContext?: ((id: string) => string) | { [id: string]: string };
   treeshake?: boolean;
+  external?:
+    | (string | RegExp)[]
+    | string
+    | RegExp
+    | ((source: string, importer: string | undefined, isResolved: boolean) => boolean | null | undefined);
 }
 
 export interface RollupOutputOptions {