Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node): add node 20 to ci #313

Merged
merged 1 commit into from
Jun 2, 2023
Merged

chore(node): add node 20 to ci #313

merged 1 commit into from
Jun 2, 2023

Conversation

rwaskiewicz
Copy link
Contributor

@rwaskiewicz rwaskiewicz commented May 18, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

We build/develop the project using Node 16

GitHub Issue Number: N/A

What is the new behavior?

this commit updates the development dependencies for the project to use node v20. by updating the versions of node/npm that volta uses, the versioning changes are/will be automatically picked up by the ci workflow (as they pull from the volta key in package.json)

Does this introduce a breaking change?

  • Yes
  • No

Testing

Unit tests continue to pass

Other information

@rwaskiewicz rwaskiewicz marked this pull request as ready for review May 18, 2023 12:49
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner May 18, 2023 12:49
this commit updates the development dependencies for the project to use
node v20. by updating the versions of node/npm that volta uses, the
versioning changes are/will be automatically picked up by the ci
workflow (as they pull from the volta key in `package.json`)
@rwaskiewicz rwaskiewicz force-pushed the rwaskiewicz/node-20 branch from 4469940 to f9fe4f7 Compare June 2, 2023 14:58
@rwaskiewicz rwaskiewicz merged commit 4ed2563 into main Jun 2, 2023
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/node-20 branch June 2, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants