Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): support to ignore certain components for SSR #540

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Nov 5, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features) see react: add docs for excludeServerSideRenderingFor option stencil-site#1494
  • Build (npm run build) was run locally for affected output targets
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently if a user provides a hydrateModule option, the output target creates server side renderable components for all components. If a user wants to slowly roll out SSR as a feature, they won't be able to without manually updating the compiled files.

What is the new behavior?

This patch introduces a new option called excludeServerSideRenderingFor which allows user to provide a list of component tags which should be excluded from being server side rendered.

Does this introduce a breaking change?

  • Yes
  • No

Other information

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants