Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): reflect aria attributes to host #316

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally for affected output targets
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Stencil components that reflect aria attributes from the host, do not work when wrapped in a Vue component.

Issue URL: ionic-team/ionic-framework#26538

What is the new behavior?

  • Vue component wrappers will reflect aria attributes from the Vue component host to the Stencil component host

Does this introduce a breaking change?

  • Yes
  • No

Other information

@rwaskiewicz rwaskiewicz enabled auto-merge (squash) January 11, 2023 15:08
@rwaskiewicz rwaskiewicz force-pushed the fix/vue-reflect-aria-attributes branch from 865ffb4 to 7a3ad37 Compare January 11, 2023 15:08
@rwaskiewicz rwaskiewicz merged commit 3129486 into main Jan 11, 2023
@sean-perkins sean-perkins deleted the fix/vue-reflect-aria-attributes branch January 11, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants