feat(environments): add process declaration (#420)

* feat(environments): add process declaration * remove @types packages after building starters quick hack because they interfere with starters build see https://www.typescriptlang.org/docs/handbook/tsconfig-json.html#types-typeroots-and-types * update app-scripts to 3.2.0
ionic-team · Aug 24, 2018 · 8cf0f06 · rdlabo · Aug 28, 2018 · imhoffd
1 parent 56f6ef1
commit 8cf0f06
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -72,6 +72,7 @@ jobs:
       - save_cache: *save-cache-src
       - run: npm run src:lint
       - run: npm run src:build
+      - run: rm -rf node_modules/@types
       - run: npm run starters:find-redundant
       - run: npm run starters:build
       - run: npm run starters:generate-checksum

diff --git a/ionic-angular/base/package.json b/ionic-angular/base/package.json
@@ -31,7 +31,7 @@
     "zone.js": "0.8.26"
   },
   "devDependencies": {
-    "@ionic/app-scripts": "3.1.11",
+    "@ionic/app-scripts": "3.2.0",
     "typescript": "~2.6.2"
   }
 }
diff --git a/ionic-angular/base/src/declarations.d.ts b/ionic-angular/base/src/declarations.d.ts
@@ -0,0 +1 @@
+declare var process: { env: { [key: string]: string | undefined; } };
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		declare var process: { env: { [key: string]: string \| undefined; } };
This comment has been minimized. Sign in to view Copy link rdlabo Aug 28, 2018 Contributor this declare causing ionic-team/ionic-cli#3541 . I know this is feature function. ionic-team/ionic-cli#3300 but if delete this declare, local Ionic CLI worked. This comment has been minimized. Sign in to view Copy link imhoffd Aug 28, 2018 Author Contributor Thanks for tracking that down @rdlabo -- I'll have to try this tomorrow. I'm not sure how `@types/node` is being installed. cc @nphyatt rdlabo reacted with thumbs up emoji