Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update events polyfill for node 10 #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SamBroner
Copy link

@SamBroner SamBroner commented Nov 27, 2020

Based on this issue #8

I noticed that I have 3 additional files created during build. In this repository do you expect those to be checked in?

Possibly @manucorporat

@SamBroner
Copy link
Author

Just because I noticed @manucorporat hasn't been active on the other open PRs, possibly @mlynch or @dwieeb? No rush! Happy holidays.

@3zzy
Copy link

3zzy commented Dec 17, 2020

Hoping this gets merged soon cause I'm having the same issue:

(!) Missing shims for Node.js built-ins
Creating a browser bundle that depends on 'events'. You might need to include https://github.com/ionic-team/rollup-plugin-node-polyfills

@SamBroner
Copy link
Author

@FredKSchott, may be relevant for @snowpackjs?

@FredKSchott
Copy link

FredKSchott commented Dec 18, 2020

@SamBroner we're going to go ahead and fork this repo, with plans to eventually bring under the official Rollup org. See rollup/plugins#51 (comment)

Would love if you could create this PR onto our repo: https://github.com/snowpackjs/rollup-plugin-node-polyfills

@SamBroner
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants