fix: NodeJS 18 compat (#275)

ionic-team · Mar 2, 2023 · 45050bb · 45050bb
1 parent d4d9ed2
commit 45050bb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/ios/lib/client/lockdownd.ts b/src/ios/lib/client/lockdownd.ts
@@ -139,7 +139,7 @@ export class LockdowndClient extends ServiceClient<LockdownProtocolClient> {
           this.protocolClient.socket,
           {
             secureContext: tls.createSecureContext({
-              secureProtocol: 'TLSv1_method',
+              secureProtocol: 'TLSv1_2_method',
               cert: pairRecord.RootCertificate,
               key: pairRecord.RootPrivateKey,
             }),

diff --git a/src/ios/lib/manager.ts b/src/ios/lib/manager.ts
@@ -110,7 +110,7 @@ export class ClientManager {
       const tlsOptions: tls.ConnectionOptions = {
         rejectUnauthorized: false,
         secureContext: tls.createSecureContext({
-          secureProtocol: 'TLSv1_method',
+          secureProtocol: 'TLSv1_2_method',
           cert: this.pairRecord.RootCertificate,
           key: this.pairRecord.RootPrivateKey,
         }),

diff --git a/src/ios/lib/protocol/protocol.ts b/src/ios/lib/protocol/protocol.ts
@@ -127,6 +127,9 @@ export abstract class ProtocolClient<MessageType = any> {
           }
         },
       );
+      this.socket.on('error', err => {
+        throw err;
+      });
       this.socket.on('data', reader.onData);
       this.writer.write(this.socket, msg);
     });