Skip to content
This repository has been archived by the owner on Jul 11, 2018. It is now read-only.

Keep the www folder #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Keep the www folder #122

wants to merge 2 commits into from

Conversation

root-io
Copy link
Contributor

@root-io root-io commented Dec 19, 2016

This error shows up if the www folder does not exist.

Error: Current working directory is not a Cordova-based project.

after running:

$ cordova platform add browser

`Error: Current working directory is not a Cordova-based project.` after `$ cordova platform add browser`
@brandyscarney
Copy link
Member

This shouldn't be an issue with the current set up. Can I ask how you are getting this error? Which command are you running? Thanks :)

@root-io
Copy link
Contributor Author

root-io commented May 5, 2017

I don't remember very well, I think because the www folder is gitignored, if you clone ionic2-app-base then push it to github, then clone your repo, the folder does not exist and cordova complains

@janpio
Copy link
Contributor

janpio commented May 11, 2017

Makes sense as /www really doesn't exist - but can easily be recreated by npm run build, ionic serve or anything that builds the project. Do you think this is reason enough to check this build result into version controll?

@root-io
Copy link
Contributor Author

root-io commented May 13, 2017

In my case I was deploying a PWA with cordova platform add browser then ionic cordova build browser --prod (not npm run build)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants