Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): popover positioning is now correct with custom elements build #23680

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jul 23, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

In v6 we use a deepReady function to wait for all stencil components to have been initialized. In the lazy loaded version, we wait for the componentOnReady function to fire. In the non-lazy loaded version we return immediately. Since customElements.define is not synchronous, we were resolving one frame too early.

This resulted in ion-popover not computing the height of the content correctly because the inner ion-content had not been initialized yet.

https://forum.ionicframework.com/t/ionic-6-popover-tab-problem/212754

What is the new behavior?

  • Wait 1 frame for the custom element to be registered

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jul 23, 2021
@liamdebeasi liamdebeasi merged commit 3a1a9cb into next Jul 26, 2021
@liamdebeasi liamdebeasi deleted the FW-92 branch July 26, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant