Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): popover positioning is now correct with custom elements build #23680

Merged
merged 2 commits into from
Jul 26, 2021
Merged

fix(vue): popover positioning is now correct with custom elements build #23680

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2e7b1c
fix race condition with deepReady
liamdebeasi Jul 23, 2021
0c9be13
perf improvement
liamdebeasi Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion core/src/utils/transition/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Build, writeTask } from '@stencil/core';

import { LIFECYCLE_DID_ENTER, LIFECYCLE_DID_LEAVE, LIFECYCLE_WILL_ENTER, LIFECYCLE_WILL_LEAVE } from '../../components/nav/constants';
import { Animation, AnimationBuilder, NavDirection, NavOptions } from '../../interface';
import { componentOnReady } from '../helpers';
import { componentOnReady, raf } from '../helpers';

const iosTransitionAnimation = () => import('./ios.transition');
const mdTransitionAnimation = () => import('./md.transition');
Expand Down Expand Up @@ -205,6 +205,19 @@ export const deepReady = async (el: any | undefined): Promise<void> => {
if (stencilEl != null) {
return;
}

/**
* Custom elements in Stencil will have __registerHost.
*/
} else if (element.__registerHost != null) {
/**
* Non-lazy loaded custom elements need to wait
* one frame for component to be loaded.
*/
const waitForCustomElement = new Promise(resolve => raf(resolve));
await waitForCustomElement;

return;
}
await Promise.all(Array.from(element.children).map(deepReady));
}
Expand Down