Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue): improve handling of parameterized urls #22360

Merged
merged 5 commits into from
Oct 22, 2020
Merged

fix(vue): improve handling of parameterized urls #22360

merged 5 commits into from
Oct 22, 2020

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Oct 20, 2020 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22359

What is the new behavior?

  • I made an incorrect assumption around the usage of strict previously. This PR brings the behavior more in line with Ionic React which does not use strict path checking.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: vue @ionic/vue package label Oct 20, 2020
@liamdebeasi liamdebeasi changed the title fix(vue): improve path matching by not forcing strict checking fix(vue): improve path matching reliability by only doing advanced path matching on leaving view Oct 20, 2020
@liamdebeasi liamdebeasi changed the title fix(vue): improve path matching reliability by only doing advanced path matching on leaving view fix(vue): improve handling of parameterized urls Oct 21, 2020
@liamdebeasi liamdebeasi mentioned this pull request Oct 22, 2020
Closed
@liamdebeasi liamdebeasi merged commit 6fad0fe into master Oct 22, 2020
@liamdebeasi liamdebeasi deleted the vue-path-match branch October 22, 2020 15:37
TakumaKira pushed a commit to TakumaKira/ionic-framework that referenced this pull request Nov 13, 2020
@liamdebeasi
fix(vue): improve handling of parameterized urls (ionic-team#22360)
e0ab4ac 
resolves ionic-team#22359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: ionic vue cannot route to shared url with param
1 participant
@liamdebeasi