Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ionic vue cannot route to shared url with param #22359

Closed
milleniumfrog opened this issue Oct 20, 2020 · 10 comments · Fixed by #22360
Closed

bug: ionic vue cannot route to shared url with param #22359

milleniumfrog opened this issue Oct 20, 2020 · 10 comments · Fixed by #22360
Labels
package: vue @ionic/vue package type: bug a confirmed bug report

Comments

@milleniumfrog
Copy link

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:
Ion Router Outlet does not display shared urls, if they contain params.
If the shared urls do not contain params it works as expected.

Expected behavior:

Shared urls should always work, even when route params are used

Steps to reproduce:

Reproduce Error

  • create shared urls with a param
    e.g. /a/:message and /app/:message/test
  • navigate to /app/:message/test without reloading the page

Sample Application

**Related code:**

<!-- If you are able to illustrate the bug or feature request with an example, please provide a sample application via one of the following means:
https://github.com/milleniumfrog/ionic_router_bug
@ionitron-bot ionitron-bot bot added the triage label Oct 20, 2020
@liamdebeasi liamdebeasi changed the title Shared urls with params do not work bug: ionic vue cannot route to shared url with param Oct 20, 2020
@liamdebeasi liamdebeasi added package: vue @ionic/vue package type: bug a confirmed bug report labels Oct 20, 2020
@ionitron-bot ionitron-bot bot removed the triage label Oct 20, 2020
@liamdebeasi liamdebeasi added this to the @ionic/vue v5.4.1 milestone Oct 20, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the issue. Can you try the following dev build and let me know if it resolves the issue?

npm install @ionic/[email protected] @ionic/[email protected] --save-exact

@milleniumfrog
Copy link
Author

The dev package solves the issue 👍 .

@milleniumfrog
Copy link
Author

I found a new related bug.

When using route parameters the routing only works the first time. If the same route is used with an other parameter routing stops working for this route

Screen Recording 2020-10-21 at 12 05 23-Apple Devices 4K (HEVC 8-bit).

I updated the ionic bug sample app https://github.com/milleniumfrog/ionic_router_bug

@liamdebeasi
Copy link
Contributor

@milleniumfrog Did you push your changes? I only see the package.json change.

@milleniumfrog
Copy link
Author

@liamdebeasi yes i forgot to push the changes. I updated it now.

@liamdebeasi
Copy link
Contributor

Thanks! Can you try this dev build? It should fix the issue:

npm install @ionic/[email protected] @ionic/[email protected] --save-exact

@milleniumfrog
Copy link
Author

The update fixed the problems 👍.

@liamdebeasi
Copy link
Contributor

Thanks for checking! I am going to keep this issue open until #22360 gets merged in.

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #22360, and a fix will be available in an upcoming release of Ionic Framework.

TakumaKira pushed a commit to TakumaKira/ionic-framework that referenced this issue Nov 13, 2020
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 21, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: vue @ionic/vue package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants