Skip to content

Commit

Permalink
fix(modal): swipe to close modal is no longer swipeable on footer (#2…
Browse files Browse the repository at this point in the history
…3401)

resolves #23398
  • Loading branch information
EinfachHans authored Jun 2, 2021
1 parent d527414 commit ae96563
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions core/src/components/modal/gestures/swipe-to-close.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ export const createSwipeToCloseGesture = (
return true;
}

const content = target.closest('ion-content');
if (content === null) {
const contentOrFooter = target.closest('ion-content, ion-footer');
if (contentOrFooter === null) {
return true;
}
// Target is in the content so we don't start the gesture.
// Target is in the content or the footer so do not start the gesture.
// We could be more nuanced here and allow it for content that
// does not need to scroll.
return false;
Expand Down

0 comments on commit ae96563

Please sign in to comment.