This repository has been archived by the owner on May 4, 2022. It is now read-only.
fix(refresherController): do not assume that user-supplied promises have a… #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… finally() method Fallback to transparent then() instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… finally() method
Fallback to transparent then() instead
Short description of what this resolves:
ionicRefresher, or whatever it's called, expects promises returned in refresh callbacks to have finally() methods. When I return a native promise from these callbacks, I want Ionic to not crash my application
Changes proposed in this pull request:
When finally() is not available, fallback to using a transparent then()
Ionic Version: 1.x