Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change Modal reference to $ionicModal #103

Merged
merged 1 commit into from
Jan 21, 2014
Merged

change Modal reference to $ionicModal #103

merged 1 commit into from
Jan 21, 2014

Conversation

DallanQ
Copy link
Contributor

@DallanQ DallanQ commented Jan 21, 2014

Without this change I was getting a ModalProvider not found error when trying to run the example under the Creating Tasks heading. It appears that the example under the Adding Projects heading has a similar issue.

mlynch added a commit that referenced this pull request Jan 21, 2014
change Modal reference to $ionicModal
@mlynch mlynch merged commit 291b8d5 into ionic-team:gh-pages Jan 21, 2014
@mlynch
Copy link
Contributor

mlynch commented Jan 21, 2014

Good call. Things have changed so quickly we got a bit backlogged on updating docs.

@DallanQ
Copy link
Contributor Author

DallanQ commented Jan 21, 2014

That was fast! Great presentation at ng-conf by the way.

@mlynch
Copy link
Contributor

mlynch commented Jan 21, 2014

Thanks, glad you liked it! Take care. 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants