-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShowWhen/HideWhen browser v2 #503
Comments
I'm going to take this one as part of ionic-team/ionic-framework#5836 & ionic-team/ionic-framework#6037 |
include a table that explains what each platform name means. references ionic-team/ionic-site#503
include links to the platform API docs and a little more information on the directives closes ionic-team/ionic-site#503
Hey @jasperkuperus, thanks for the issue! I updated the Platform docs & demo to have a bit more information. This can be seen on our staging site here: http://ionic-site-staging.herokuapp.com/docs/v2/api/platform/Platform/ And I updated the showWhen/hideWhen docs & demo here: Please let me know if you have any feedback or ways to improve. Thanks! 😄 |
Looks great! Thanks :) |
I was playing with
showWhen
and thought I'd had my bases covered with this snippet:However, testing in the browser did not show anything, even though the class
ios
is on the body. Upon further investigation, I got it to work usingshowWhen="ios,core"
.The
Platform
documentation is quite straightforward, but leaves some room for interpretation oncore
. I had to test on some devices to find out whethercore
was something that's always applicable, or only in the browser. The latter seems to be the case.Also, a link from the
hideWhen
andshowWhen
documentation to thePlatform
documentation might be a welcome addition as I was not yet aware of there being more platforms than the ones demonstrated in those examples.The text was updated successfully, but these errors were encountered: