Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShowWhen/HideWhen browser v2 #503

Closed
jasperkuperus opened this issue Mar 13, 2016 · 3 comments
Closed

ShowWhen/HideWhen browser v2 #503

jasperkuperus opened this issue Mar 13, 2016 · 3 comments
Assignees

Comments

@jasperkuperus
Copy link

I was playing with showWhen and thought I'd had my bases covered with this snippet:

<span primary showWhen="ios">Cancel</span>
<ion-icon name="md-close" showWhen="android,windows"></ion-icon>

However, testing in the browser did not show anything, even though the class ios is on the body. Upon further investigation, I got it to work using showWhen="ios,core".

The Platform documentation is quite straightforward, but leaves some room for interpretation on core. I had to test on some devices to find out whether core was something that's always applicable, or only in the browser. The latter seems to be the case.

Also, a link from the hideWhen and showWhen documentation to the Platform documentation might be a welcome addition as I was not yet aware of there being more platforms than the ones demonstrated in those examples.

@brandyscarney
Copy link
Member

I'm going to take this one as part of ionic-team/ionic-framework#5836 & ionic-team/ionic-framework#6037

@perrygovier perrygovier added this to the Sprint #2 milestone Apr 13, 2016
brandyscarney added a commit to ionic-team/ionic-framework that referenced this issue Apr 15, 2016
include a table that explains what each platform name means.

references ionic-team/ionic-site#503
brandyscarney added a commit to ionic-team/ionic-framework that referenced this issue Apr 18, 2016
include links to the platform API docs and a little more information on
the directives

closes ionic-team/ionic-site#503
@brandyscarney
Copy link
Member

Hey @jasperkuperus, thanks for the issue! I updated the Platform docs & demo to have a bit more information. This can be seen on our staging site here: http://ionic-site-staging.herokuapp.com/docs/v2/api/platform/Platform/

And I updated the showWhen/hideWhen docs & demo here:
http://ionic-site-staging.herokuapp.com/docs/v2/api/components/show-hide-when/ShowWhen/
http://ionic-site-staging.herokuapp.com/docs/v2/api/components/show-hide-when/HideWhen/

Please let me know if you have any feedback or ways to improve. Thanks! 😄

@jasperkuperus
Copy link
Author

Looks great! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants