Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled input fix #9676

Merged
merged 4 commits into from
Dec 19, 2016
Merged

Disabled input fix #9676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
501c6a7
test(input): add disabled input
jgw96 Dec 16, 2016
61ee1d6
Merge branch 'master' of https://github.com/driftyco/ionic
jgw96 Dec 16, 2016
9ab00dd
fix(input): fixes #9070
jgw96 Dec 16, 2016
a44dc6f
chore(input): cleanup
jgw96 Dec 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/input/input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ ion-textarea {
width: 100%;
}


.item-input ion-input,
.item-input ion-textarea {
position: static;
}


// Textarea Within An Item
// --------------------------------------------------

Expand Down Expand Up @@ -64,7 +64,6 @@ textarea.text-input {
opacity: .4;
}


input.text-input:-webkit-autofill {
background-color: transparent;
}
Expand All @@ -81,6 +80,7 @@ input.text-input:-webkit-autofill {
// This make it so the native input element is not clickable.
// This will only show when the scroll assist is configured
// otherwise the .input-cover will not be rendered at all
// The input cover is not clickable when the input is disabled

.input-cover {
position: absolute;
Expand All @@ -91,6 +91,10 @@ input.text-input:-webkit-autofill {
height: 100%;
}

ion-input[disabled] .input-cover {
pointer-events: none;
}


// Input Cover: Focused
// --------------------------------------------------
Expand Down
5 changes: 5 additions & 0 deletions src/components/input/test/input-focus/main.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,11 @@
<ion-input value="inline input 1"></ion-input>
</ion-item>

<ion-item>
<ion-label>Disabled Input:</ion-label>
<ion-input disabled value="disabled input 1"></ion-input>
</ion-item>

</ion-list>

</ion-content>