fix:(tabs/view-controller) keep changedetector #9578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keep the change detector when selecting a tab without a [root]
|
Hi @dominikstrasser, thanks for your PR. But there is already one opened to fix this issue: |
|
@manucorporat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Keeps the change detector attached when selecting a tab wich has not [root] page set.
related Issue
#9577
Changes proposed in this pull request:
keepChangeDetectorAttached) toviewcontroller._didLeave()Ionic Version: 1.x / 2.x
Fixes: #
keep the change detector when selecting a tab without a [root]