Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(range): adding the resolution property for the range #9098

Closed
wants to merge 2 commits into from
Closed

feat(range): adding the resolution property for the range #9098

wants to merge 2 commits into from

Conversation

PAFsec
Copy link

@PAFsec PAFsec commented Nov 10, 2016

Enhancement

Add of a resolution property in the ion-range component in order to select the number of decimals needed by the developper.

Ionic Version: 2.x

Issue: #6812

manucorporat
manucorporat suggested changes Nov 11, 2016
View reviewed changes
src/components/range/range.ts Outdated
*/
@Input()
get resolution(): number {
//console.log('retur')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this comment line?

@leveque01
Copy link

Any news about this ?

@PAFsec PAFsec mentioned this pull request Jul 3, 2017
Closed
@Ionitron
Copy link
Collaborator

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!

@Ionitron Ionitron closed this Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manucorporat manucorporat manucorporat requested changes

Assignees

@manucorporat manucorporat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PAFsec @leveque01 @Ionitron @manucorporat @brandyscarney