fix(animation): _beforeRead/Write is always called #9033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2016
manucorporat
force-pushed
the
animation-bug
branch
from
8c7a9d9 to
972ed8c
Compare
manucorporat
force-pushed
the
animation-bug
branch
from
972ed8c to
0e53ec3
Compare
manucorporat
force-pushed
the
animation-bug
branch
2 times, most recently
from
8e83cc1 to
90441d9
Compare
manucorporat
force-pushed
the
animation-bug
branch
from
90441d9 to
15b224a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Changes proposed in this pull request:
Ionic Version: 1.x / 2.x
Fixes: #
A very short animation could actually call didFinish before _beforeReadFn() since the animation is invalidated once it finishes
_beforeReadFn is never called.
NavigationController depends on this behavior to work properly.
Fixes #8842