Fix #841 Don't wrap ion-content content in a .scroll element #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! And well tested :-) I don't think we can support the re-compilation, and that's OK. Could you add something to the docs for the scroll attribute to note this? Something like 'Note: attribute is not watched - no-scroll effect happens upon element compilation' |
|
Done |
|
Thanks @jayproulx! We're cutting a release now, I'll wait to merge it until after that, since it is a 'risky' change. |
|
final-reviewing this for merge now now. |
|
I got sidetracked and forgot to finish merging it. Done! Thanks @jayproulx! keep it up. Awesome PR, with questions asked, tests written, and followup accomplished. |
|
Hey, awesome framework, I'm glad to contribute. I expect we'll be using it quite a bit in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #841
Downside is that the scroll property is immutable, unless you've got a clean way to $compile on a scope change. Is this likely to be a real-world scenario?