Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): isActive="false" with ios mode #8546

Merged
merged 1 commit into from
Oct 10, 2016

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Oct 6, 2016

Short description of what this resolves:

#8435

Before: (red failing cases)
screen shot 2016-10-08 at 17 39 27
screen shot 2016-10-08 at 17 39 58

After:

screen shot 2016-10-08 at 17 36 39

screen shot 2016-10-08 at 17 36 52

Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good as long as it passes snapshot. 👍

@manucorporat
Copy link
Contributor Author

@brandyscarney @adamdbradley same thing here. I could not run snapshot. But the scope of this change is very limited, purely a logic change. No css.

I added additional e2e tests for the cases it used to fail, and previous ones continue working.

For me, it is ready to be merged.

I would not delay it until snapshot and build gets faster, we can always run snapshot before releasing RC1.

@adamdbradley adamdbradley merged commit bcbe03c into ionic-team:master Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants