Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): menu's content is resized properly #8514

Merged
merged 1 commit into from
Oct 10, 2016

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Oct 5, 2016

Short description of what this resolves:

Before fix:
screen shot 2016-10-05 at 21 22 24
screen shot 2016-10-05 at 21 22 34

footer and part of the content is hidden.

After:
screen shot 2016-10-05 at 19 40 28
screen shot 2016-10-05 at 19 40 36

fixes #8504

@manucorporat manucorporat changed the title fix(menu): behaves like main content fix(menu): menu's content is resized properly Oct 8, 2016
@manucorporat
Copy link
Contributor Author

manucorporat commented Oct 8, 2016

@adamdbradley @brandyscarney I could not run snapshot, but I have tested manually in both desktop and device. Chrome and safari.

I consider this is important bug, since it affects the menu's content layout in safari in a pretty bad way (content is hidden).

@adamdbradley adamdbradley merged commit db72a7d into ionic-team:master Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side menu with header: scroll container extends below viewport
2 participants