Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(fab): add docs variables SASS #8456

Merged
merged 2 commits into from
Oct 5, 2016
Merged

docs(fab): add docs variables SASS #8456

merged 2 commits into from
Oct 5, 2016

Conversation

ramonornela
Copy link
Contributor

Short description of what this resolves:

Changes proposed in this pull request:

Ionic Version: 2.0.0-rc.0

Fixes: #

brandyscarney
brandyscarney reviewed Oct 3, 2016
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could we capitalize FAB in all of them? :)

@ramonornela
Copy link
Contributor Author

ramonornela commented Oct 3, 2016 •
edited
Loading

@brandyscarney Because other are capitalized in md, ios and wp 😉

@brandyscarney
Copy link
Member

@ramonornela Sorry, I don't understand. I am asking if you could make them all FAB? The last two are written as Fab. Just to keep it consistent.

@brandyscarney brandyscarney merged commit 63c6d46 into ionic-team:master Oct 5, 2016
@brandyscarney
Copy link
Member

Perfect. Thank you!

@ramonornela
Copy link
Contributor Author

Thanks

Sorry I was driving at the moment, I only saw the first comments 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramonornela @brandyscarney