Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scroll-content class and scroll element if scroll="false" #843

Closed
wants to merge 1 commit into from
Closed

Conversation

jayproulx
Copy link

Potential fix for #841

This pull request is not complete, just meant to generate discussion around a fix for #841. If scroll="false", we don't want any scrolling behaviour, and to remove the scroll element so that we have access to the parent container height.

@mlynch
Copy link
Contributor

mlynch commented Mar 20, 2014

Thanks @jayproulx. Closing as per discussion on #841.

@mlynch mlynch closed this Mar 20, 2014
@jayproulx
Copy link
Author

Will a pane also get the header/footer treatment that the ion-content does? I'm still not quite getting what I need out of ion-pane, since part of my content is hidden by the header or footer. I can pad that out myself, but I need to guess at whether we're on ios7 or not, etc. I get that for free with ion-content.

Is there a negative side effect to removing the scroll element and scroll-content class?

@ajoslin
Copy link
Contributor

ajoslin commented Mar 21, 2014

Add the .has-header or .has-footer class to your ion-pane.

@jayproulx
Copy link
Author

I've been digging through documentation and the source, I can't seem to find the ionPane options.

ion-pane only adds a css class here:
https://github.com/driftyco/ionic/blob/e94d400648a0770cea3909e2d2513c71e88978ae/js/ext/angular/src/directive/ionicContent.js

And there's no reference in the docs here:
https://www.google.ca/search?q=ion-pane+site%3Aionicframework.com%2Fdocs

If I add has-header=true I just see this:
http://codepen.io/anon/pen/xusel

So it seems there's a gap, either ion-content should be extended to provide all of it's other features and optionally scroll, or ion-pane needs to duplicate ion-content so that it gets the has-header/has-footer features of ion-content. I'm happy to help create a pull request for either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants