Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): consecutive inset lists with headers #8413

Merged
merged 1 commit into from
Oct 10, 2016
Merged

fix(list): consecutive inset lists with headers #8413

merged 1 commit into from
Oct 10, 2016

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Oct 2, 2016 •
edited
Loading

Short description of what this resolves:

Fixes #8412

After fix:
screen shot 2016-10-03 at 14 22 48

@brandyscarney can you review it?!

@brandyscarney brandyscarney added this to the 2.0.0-rc.1 milestone Oct 3, 2016
@brandyscarney
Copy link
Member

I'll review this once I get the e2e tests up and running!

@manucorporat
Copy link
Contributor Author

manucorporat commented Oct 3, 2016 •
edited
Loading

@brandyscarney awesome! try commenting out the fix, the e2e test should look bad ;) I hope it does not break anything 🍀

brandyscarney
brandyscarney requested changes Oct 6, 2016
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look right if you have a non inset list followed by an inset list. This only works for consecutive inset lists.

@brandyscarney
Copy link
Member

screen shot 2016-10-06 at 3 44 29 pm

@manucorporat
Copy link
Contributor Author

Good catch. Adding tests and fix.

@manucorporat
Copy link
Contributor Author

@brandyscarney fixed
screen shot 2016-10-06 at 22 32 02

@adamdbradley adamdbradley merged commit 93616c4 into ionic-team:master Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney requested changes

Assignees

@adamdbradley adamdbradley

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

Consecutive inset lists with header
3 participants
@manucorporat @brandyscarney @adamdbradley