Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): open/close race condition #8068

Merged
merged 1 commit into from
Sep 14, 2016
Merged

fix(menu): open/close race condition #8068

merged 1 commit into from
Sep 14, 2016

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Sep 13, 2016 •
edited
Loading

Short description of what this resolves:

#7629
#8001

Changes proposed in this pull request:

  • setOpen() is noop while actively swiping
  • Menu swipe gesture is not captured if the menu is actively moving (being animated)

fixes #7629 #8001

@manucorporat manucorporat mentioned this pull request Sep 13, 2016
Closed
@jgw96 jgw96 mentioned this pull request Sep 13, 2016
Closed
@manucorporat manucorporat force-pushed the fix-blank-menu branch 2 times, most recently from 5b1a33e to 1ec305c Compare September 14, 2016 16:18
@adamdbradley adamdbradley merged commit 8585427 into ionic-team:master Sep 14, 2016
@adamdbradley adamdbradley added this to the 2.0.0-beta.12 milestone Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.12
Development

Successfully merging this pull request may close these issues.

bug: menu is not getting correct classes added on open
2 participants
@manucorporat @adamdbradley