Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datetime): pass roles to overlay when dismissing #29221

Merged
merged 7 commits into from
Apr 3, 2024
Merged

feat(datetime): pass roles to overlay when dismissing #29221

merged 7 commits into from
Apr 3, 2024

Conversation

Rahul-28
Copy link
Contributor

@Rahul-28 Rahul-28 commented Mar 26, 2024 •
edited
Loading

Issue number: resolves #28298

What is the current behavior?

  • the ion-datetime didn't provide a role(source trigger for closing the overlay) on default buttons while closing parent overlay

What is the new behavior?

  • ion-datetime provides a role to default buttons while closing the parent overlay

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@github-actions github-actions bot added the package: core @ionic/core package label Mar 26, 2024
@Rahul-28 Rahul-28 mentioned this pull request Mar 27, 2024
Closed
3 tasks
liamdebeasi
liamdebeasi suggested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR!

core/src/components/datetime/test/overlay-roles/index.html Outdated Show resolved Hide resolved
core/src/components/datetime/test/overlay-roles/index.html Outdated Show resolved Hide resolved
core/src/components/datetime/test/overlay-roles/index.html Outdated Show resolved Hide resolved
core/src/components/datetime/test/overlay-roles/index.html Outdated Show resolved Hide resolved
@liamdebeasi liamdebeasi changed the title feat(date-time): add Overlay roles feat(datetime): pass roles to overlay when dismissing Mar 28, 2024
@Rahul-28
Copy link
Contributor Author

Rahul-28 commented Mar 29, 2024 •
edited
Loading

@liamdebeasi I have updated the PR, can you please look into it

@Rahul-28
Copy link
Contributor Author

Rahul-28 commented Apr 3, 2024

hey @liamdebeasi the lint issues are fixed can you please review my changes

@liamdebeasi liamdebeasi changed the base branch from main to feature-8.1 April 3, 2024 17:52
liamdebeasi
liamdebeasi approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and this works great. Thank you!

@Rahul-28
Copy link
Contributor Author

Rahul-28 commented Apr 3, 2024 •
edited
Loading

@liamdebeasi Thank you

@liamdebeasi liamdebeasi merged commit 6945adc into ionic-team:feature-8.1 Apr 3, 2024
42 checks passed
@liamdebeasi
Copy link
Contributor

Merged, thanks again!

@l00pinfinity l00pinfinity mentioned this pull request Jun 15, 2024
Closed
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

@averyjohnston averyjohnston Awaiting requested review from averyjohnston

@sean-perkins sean-perkins Awaiting requested review from sean-perkins

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: ion-datetime: supply modal role on default buttons
2 participants
@Rahul-28 @liamdebeasi