Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

ionic-team / ionic-framework Public

Notifications You must be signed in to change notification settings
Fork 13.5k
Star 51.3k

Code
Issues 512
Pull requests 34
Discussions
Actions
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Wiki
Security
Insights

fix(modal): ariaLabel and role are inherited when set via htmlAttributes#29099

Merged

liamdebeasi merged 4 commits intomainionic-team/ionic-framework:mainfrom FW-5899ionic-team/ionic-framework:FW-5899Copy head branch name to clipboard

Feb 29, 2024

+78-25

Conversation Commits4 (4)Checks Files changed

Commits

Commits on Feb 28, 2024

test(modal): add 1 passing and 1 failing test, remove redundant test
liamdebeasi
committed
update test
liamdebeasi
committed
fix(modal): ariaLabel and role are inherited when set via htmlAttributes
liamdebeasi
committed
chore: lint
liamdebeasi
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.