refactor(breadcrumb): use new step color tokens #28930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapsandapps
requested review from
averyjohnston
and removed request for
a team
| @@ -4,22 +4,22 @@ | |||
| // -------------------------------------------------- | |||
|
|
|||
| /// @prop - Color of the breadcrumb | |||
| $breadcrumb-ios-color: var(--ion-color-step-850, #2d4665) !default; | |||
| $breadcrumb-ios-color: var(--ion-color-step-850, var(--ion-text-color-step-850, #2d4665)) !default; | |||
There was a problem hiding this comment.
My understanding from looking at the design doc was that for text colors, the step count needs to be flipped (e.g. 850 -> 150). I think there aren't any diffs because these all have fallback colors? I'm not 100% confident I know how it all works, to be honest 😆
There was a problem hiding this comment.
Your understanding is correct. The legacy stepped colors go from white (the background) to black (the text color). However, when using the new text step colors those always go from black (the text color) to white (the background) when in light mode. That's why we need to invert the numbers for the text color tokens only.
|
Ok, I think this is finally good to go. We decided that
|
brandyscarney
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
The breadcrumbs use the
--ion-color-steptokens or a fallback.What is the new behavior?
--ion-color-steptokens or the--ion-text-color-steptokens or a fallback--ion-color-steptokens or the--ion-background-color-steptokens or a fallbackDoes this introduce a breaking change?