Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(popover): content inside of popover scrolls correctly #28861

Merged
merged 4 commits into from
Jan 23, 2024
Merged

fix(popover): content inside of popover scrolls correctly #28861

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77666f8
fix(popover): content inside of popover scrolls correctly
liamdebeasi Jan 19, 2024
215ed5e
chore(): add updated snapshots
Ionitron Jan 19, 2024
1c294a1
chore: regen screenshots
liamdebeasi Jan 19, 2024
d4c58a6
chore(): add updated snapshots
Ionitron Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/components/popover/popover.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
z-index: $z-index-overlay-wrapper;
}

.popover-viewport {
::slotted(.popover-viewport) {
--ion-safe-area-top: 0px;
--ion-safe-area-right: 0px;
--ion-safe-area-bottom: 0px;
Expand Down
Binary file modified ...er.e2e.ts-snapshots/popover-basic-header-popover-md-ltr-Mobile-Safari-linux.png
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We previously changed the box shadow, but this screenshot was not updated due to our diff threshold.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...pshots/popover-basic-translucent-header-popover-ios-ltr-Mobile-Chrome-linux.png
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This screenshot was actually captured incorrectly originally. There is a footer in the test template, but due to .popover-viewport not applying the ion-content height was so large that the footer was pushed outside the viewport.

I decided not to add another screenshot because this test already captures the effects of the proposed changes and would fail if the changes were reverted in the future.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...shots/popover-basic-translucent-header-popover-ios-ltr-Mobile-Firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...pshots/popover-basic-translucent-header-popover-ios-ltr-Mobile-Safari-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...t-popover.e2e.ts-snapshots/select-popover-diff-ios-ltr-Mobile-Firefox-linux.png
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been updated previously, but likely was not updated due to our diff threshold. The new screenshot aligns with screenshots in main: https://github.com/ionic-team/ionic-framework/blob/9262f7da15969706039e9d5f11ef5c7bd73ced0d/core/src/components/select-popover/test/basic/select-popover.e2e.ts-snapshots/select-popover-diff-ios-ltr-Mobile-Chrome-linux.png

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ct-popover.e2e.ts-snapshots/select-popover-diff-md-ltr-Mobile-Firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ....e2e.ts-snapshots/select-popover-multiple-diff-ios-ltr-Mobile-Firefox-linux.png
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been updated previously, but likely was not updated due to our diff threshold. The new screenshot aligns with screenshots in main: https://github.com/ionic-team/ionic-framework/blob/9262f7da15969706039e9d5f11ef5c7bd73ced0d/core/src/components/select-popover/test/basic/select-popover.e2e.ts-snapshots/select-popover-multiple-diff-ios-ltr-Mobile-Chrome-linux.png

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...r.e2e.ts-snapshots/select-popover-multiple-diff-md-ltr-Mobile-Firefox-linux.png
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been updated previously, but likely was not updated due to our diff threshold. The new screenshot aligns with screenshots in main: https://github.com/ionic-team/ionic-framework/blob/9262f7da15969706039e9d5f11ef5c7bd73ced0d/core/src/components/select-popover/test/basic/select-popover.e2e.ts-snapshots/select-popover-multiple-diff-md-ltr-Mobile-Safari-linux.png

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading