Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): add old IonBackButtonDelegate import #28831

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 15, 2024

Issue number: resolves #28827


What is the current behavior?

This import was renamed to IonBackButton as part of 9f20780. However, we did not consider that some developers are importing this to use with ViewChild. While we should keep alignment with other component imports, we need to support the old import until we can make a breaking change in Ionic 8.

What is the new behavior?

  • Adds the old IonBackButtonDelegate import

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 7.6.5-dev.11705352188.1c6cdb08

@liamdebeasi liamdebeasi added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit fb77353 Jan 16, 2024
56 checks passed
@liamdebeasi liamdebeasi deleted the FW-5888 branch January 16, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Module '"@ionic/angular"' has no exported member 'IonBackButtonDelegate'
2 participants