feat(picker-column): add styles, disabled and active states #28621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
commented
Dec 1, 2023
| * Default options are: `"primary"`, `"secondary"`, `"tertiary"`, `"success"`, `"warning"`, `"danger"`, `"light"`, `"medium"`, and `"dark"`. | ||
| * For more information on colors, see [theming](/docs/theming/basics). | ||
| */ | ||
| @Prop({ reflect: true }) color?: Color = 'primary'; |
There was a problem hiding this comment.
This is currently on the picker-column component but will be removed once picker-column-option is fully integrated.
github-actions
bot
added
package: angular
2 tasks
thetaPC
reviewed
Dec 4, 2023
sean-perkins
reviewed
Dec 5, 2023
| @@ -0,0 +1 @@ | |||
| @import "./picker-column-option.scss"; | |||
There was a problem hiding this comment.
Our existing components leave off the file extension with importing another SASS file.
sean-perkins
reviewed
Dec 5, 2023
| @@ -0,0 +1,5 @@ | |||
| @import "./picker-column-option.scss"; | |||
There was a problem hiding this comment.
Our existing components leave off the file extension with importing another SASS file.
sean-perkins
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
We'd like to introduce a new API to the picker column to allow developers to manipulate the picker options right in the DOM. Currently developers need to pass an object which is quite cumbersome as you need to re-pass that object anytime you want to change a single option.
What is the new behavior?
This PR does some of the prep work to make integrating the picker column option into picker column easier. It does the following things:
Note: There are duplicate styles across picker-column and picker-column-option that will be cleaned up once picker-column-option is integrated and shown to be functional.
Does this introduce a breaking change?
Other information