Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): collapsible large title does not flicker when collapse prop not reflected #28472

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix(header): collapsible large title does not flicker when collapse prop not reflected #28472

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db450b0
fix(header): collapsible large title does not flicker when collapse p…
liamdebeasi Nov 6, 2023
6a97c19
Update core/src/components/header/header.ios.scss
liamdebeasi Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/components/header/header.ios.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@
* 2. This will only apply when that content has a collapse header (ion-header[collapse="condense"])
*
* We use opacity: 0 to avoid a layout shift.
* We target both the attribute and the class in the event that the attribute
* is not reflected on the host in some frameworks.
*/
ion-header:not(.header-collapse-main):has(~ ion-content ion-header[collapse="condense"]) {
ion-header:not(.header-collapse-main):has(~ ion-content ion-header[collapse="condense"], ~ ion-content ion-header.header-collapse-condense) {
liamdebeasi marked this conversation as resolved.
Show resolved Hide resolved
opacity: 0;
}
Loading