test(playwright): enable github reporter, test retries #27961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
changed the title
revert test
liamdebeasi
requested review from
a team and
mapsandapps
and removed request for
a team
sean-perkins
approved these changes
Aug 10, 2023
mapsandapps
suggested changes
Aug 10, 2023
| @@ -63,13 +63,16 @@ const config: PlaywrightTestConfig = { | |||
| /* Fail the build on CI if you accidentally left test.only in the source code. */ | |||
| forbidOnly: !!process.env.CI, | |||
| /* Fail fast on CI */ | |||
There was a problem hiding this comment.
i think this comment needs to be removed?
There was a problem hiding this comment.
Good catch! Addressed in #27973
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Issue number: # --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Shawn noted that I had an outdated comment in the `playwright.config.ts` file when working on #27961: #27961 (review) ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Remove the old comment ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The team would like to explore solutions for being informed of flaky tests in a way that is not disruptive to our workflow. Currently, flaky tests fail immediately which means we have to re-run them every time. We'd like flaky tests to be automatically retried but also reported to us so we can address them in a separate PR.
What is the new behavior?
Does this introduce a breaking change?
Other information