Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab-button): use darker text to pass a11y #27355

Merged
merged 16 commits into from
May 11, 2023
Merged

fix(tab-button): use darker text to pass a11y #27355

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3172987
fix(tab-button): use darker text to pass a11y
brandyscarney May 2, 2023
1019862
Merge branch 'main' into FW-3604
brandyscarney May 3, 2023
aa9b973
test(tab-button): remove rule disable for axe
brandyscarney May 3, 2023
08a9b6b
chore(): add updated snapshots
Ionitron May 3, 2023
c4b3e60
Merge remote-tracking branch 'origin/main' into FW-3604
liamdebeasi May 9, 2023
e08d9e6
chore(): add updated snapshots
Ionitron May 9, 2023
4c40f18
remove MD screenshots to regenerate
liamdebeasi May 10, 2023
f840696
chore(): add updated snapshots
Ionitron May 11, 2023
b42271c
Merge branch 'main' into FW-3604
brandyscarney May 11, 2023
7acb6a8
Revert "chore(): add updated snapshots"
brandyscarney May 11, 2023
881e8b7
chore(): add updated snapshots
Ionitron May 11, 2023
82182e0
Revert "chore(): add updated snapshots"
brandyscarney May 11, 2023
2c55d14
Revert "chore(): add updated snapshots"
brandyscarney May 11, 2023
dd2049a
Revert "chore(): add updated snapshots"
brandyscarney May 11, 2023
827b4d0
Merge branch 'main' into FW-3604
brandyscarney May 11, 2023
1e1ed0d
chore(): add updated snapshots
Ionitron May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/src/components/tab-button/test/a11y/tab-button.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ configs().forEach(({ title, config }) => {
test('should not have any axe violations', async ({ page }) => {
await page.goto('/src/components/tab-button/test/a11y', config);

// TODO FW-3604
const results = await new AxeBuilder({ page }).disableRules('color-contrast').analyze();
const results = await new AxeBuilder({ page }).analyze();
expect(results.violations).toEqual([]);
});
});
Expand Down
Binary file modified ...ic/tab-button.e2e.ts-snapshots/tab-button-badge-ios-ltr-Mobile-Chrome-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ic/tab-button.e2e.ts-snapshots/tab-button-badge-ios-rtl-Mobile-Chrome-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion core/src/themes/ionic.theme.default.ios.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ $overlay-ios-background-color: var(--ion-overlay-background-color,
$tabbar-ios-background: var(--ion-tab-bar-background, var(--ion-color-step-50, #f7f7f7)) !default;
$tabbar-ios-background-focused: var(--ion-tab-bar-background-focused, get-color-shade(#fff)) !default;
$tabbar-ios-border-color: var(--ion-tab-bar-border-color, var(--ion-border-color, var(--ion-color-step-150, rgba(0, 0, 0, .2)))) !default;
$tabbar-ios-color: var(--ion-tab-bar-color, $text-color-step-600) !default;
$tabbar-ios-color: var(--ion-tab-bar-color, $text-color-step-400) !default;
$tabbar-ios-color-selected: var(--ion-tab-bar-color-selected, ion-color(primary, base)) !default;

// iOS Toolbar
Expand Down
2 changes: 1 addition & 1 deletion core/src/themes/ionic.theme.default.md.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ $overlay-md-background-color: var(--ion-overlay-background-color,
$tabbar-md-background: var(--ion-tab-bar-background, $background-color) !default;
$tabbar-md-background-focused: var(--ion-tab-bar-background-focused, get-color-shade(#fff)) !default;
$tabbar-md-border-color: var(--ion-tab-bar-border-color, var(--ion-border-color, var(--ion-color-step-150, rgba(0, 0, 0, .07)))) !default;
$tabbar-md-color: var(--ion-tab-bar-color, $text-color-step-400) !default;
$tabbar-md-color: var(--ion-tab-bar-color, $text-color-step-350) !default;
brandyscarney marked this conversation as resolved.
Show resolved Hide resolved
$tabbar-md-color-selected: var(--ion-tab-bar-color-selected, ion-color(primary, base)) !default;

// Material Design Toolbar
Expand Down