Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): canDismiss type with data and role #26547

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Dec 29, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The new changes in Ionic 6.4.0 for canDismiss to accept role and data is not reflected on the ModalOptions interface.

Issue URL: #26544

What is the new behavior?

  • Adds the missing type definition for canDismiss to the ModalOptions interface

Does this introduce a breaking change?

  • Yes
  • No

Other information

Related docs PR: ionic-team/ionic-docs#2686

@github-actions github-actions bot added the package: core @ionic/core package label Dec 29, 2022
@sean-perkins sean-perkins marked this pull request as ready for review January 3, 2023 15:38
@sean-perkins sean-perkins requested a review from a team as a code owner January 3, 2023 15:38
@sean-perkins sean-perkins merged commit 32c2622 into main Jan 4, 2023
@sean-perkins sean-perkins deleted the fix/modal-interface branch January 4, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants