Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datetime): use scroll listener to detect month changes #25586

Merged
merged 25 commits into from
Jul 15, 2022
Merged

refactor(datetime): use scroll listener to detect month changes #25586

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
3b5d694
refactor(datetime): use scroll listener to detect month changes
liamdebeasi Jul 7, 2022
eaf0b87
chore(): remove webkit workaround
liamdebeasi Jul 7, 2022
418407e
chore(): lint
liamdebeasi Jul 7, 2022
30fda45
chore(): tweak timeout
liamdebeasi Jul 7, 2022
96ef7ab
Revert "chore(): remove webkit workaround"
liamdebeasi Jul 7, 2022
886c771
chore(): update comment
liamdebeasi Jul 7, 2022
53a167e
chore(): fix wording
liamdebeasi Jul 7, 2022
d872abb
chore(): add todo
liamdebeasi Jul 7, 2022
b31b52b
chore(): lint
liamdebeasi Jul 7, 2022
a644f95
fix(datetime): apply snapping fix for ios
liamdebeasi Jul 7, 2022
9f213d1
chore(): clean up
liamdebeasi Jul 7, 2022
e879837
chore(): make timeout a bit faster
liamdebeasi Jul 7, 2022
ce88463
perf(datetime): avoid unnecessary work on ios
liamdebeasi Jul 8, 2022
8e0f2d1
Merge branch 'main' into datetime-scroll-listener
liamdebeasi Jul 8, 2022
47696a6
Update datetime.tsx
liamdebeasi Jul 12, 2022
7c65469
Update datetime.tsx
liamdebeasi Jul 12, 2022
6538ad4
remove unneeded tests
liamdebeasi Jul 14, 2022
8e4b234
fix(datetime): do not update dom if swipe in progress
liamdebeasi Jul 14, 2022
fd814ad
chore(): add comment
liamdebeasi Jul 14, 2022
866ddaf
Merge branch 'main' into datetime-scroll-listener
liamdebeasi Jul 14, 2022
ce571dc
chore(): remove old logic
liamdebeasi Jul 14, 2022
9f56f25
Merge branch 'datetime-scroll-listener' of https://github.com/ionic-t…
liamdebeasi Jul 14, 2022
4ce6f41
fix(datetime): improve patch for zoomed pages
liamdebeasi Jul 14, 2022
14b8373
Merge branch 'main' into datetime-scroll-listener
sean-perkins Jul 15, 2022
9f58b30
Merge branch 'main' into datetime-scroll-listener
liamdebeasi Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions core/src/components/datetime/datetime.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,8 @@
}

/**
* Safari 14 has an issue where Intersection
* Observer is incorrectly fired when
* unhiding the calendar content.
* Safari 14 has an issue where a scroll event
* is incorrectly fired when unhiding the calendar content.
* To workaround this, we set the opacity
* of the content to 0 and hide it offscreen.
*
Expand Down
Loading