Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): warn devs that standalone components are not supported #25516

Merged
merged 6 commits into from
Jun 23, 2022
Merged

fix(angular): warn devs that standalone components are not supported #25516

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ecc9dd6
fix(angular): warn devs that standalone components are not supported
sean-perkins Jun 21, 2022
0ebb639
chore(): adjust messaging and formatting
sean-perkins Jun 21, 2022
3968d31
chore(): rework warning and document purpose
sean-perkins Jun 22, 2022
686833b
Merge branch 'main' into FW-1657
sean-perkins Jun 22, 2022
ed7b9b7
Merge branch 'main' into FW-1657
sean-perkins Jun 23, 2022
41f5b46
refactor(): check if component is not set
sean-perkins Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions angular/src/directives/navigation/ion-router-outlet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,25 @@ export class IonRouterOutlet implements OnDestroy, OnInit {
this.updateActivatedRouteProxy(cmpRef.instance, activatedRoute);
} else {
const snapshot = (activatedRoute as any)._futureSnapshot;

// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
const component = snapshot.routeConfig!.component as any;

/**
* Angular 14 introduces a new `loadComponent` property to the route config,
* that assigns the component to load to the `component` property of
* the route snapshot. We can check for the presence of this property
* to determine if the route is using standalone components.
*
* TODO: FW-1631: Remove this check when supporting standalone components
*/
if (component == null && snapshot.component) {
console.warn(
'[Ionic Warning]: Standalone components are not currently supported with ion-router-outlet. You can track this feature request at https://github.com/ionic-team/ionic-framework/issues/25404'
);
return;
}

const childContexts = this.parentContexts.getOrCreateContext(this.name).children;

// We create an activated route proxy object that will maintain future updates for this component
Expand Down