Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): ensure popover does not go offscreen when adjusting top position #25350

Merged
merged 8 commits into from
Jun 9, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented May 25, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25349

What is the new behavior?

  • When adjusting the top position of the popover, call Math.max so that the position is next < 0. The trade off here is that the popover may not perfectly align with the coordinates of the trigger. However, the alternative here would be to keep the popover below the trigger and have the browser resize the popover to be really small (which does not seem very useful).

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label May 25, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review May 25, 2022 15:46
@liamdebeasi liamdebeasi requested a review from a team as a code owner May 25, 2022 15:46
@liamdebeasi liamdebeasi requested a review from averyjohnston May 26, 2022 16:20
@averyjohnston
Copy link
Contributor

Now the popover always opens in the same spot, instead of at your mouse cursor; was that intentional?

@liamdebeasi
Copy link
Contributor Author

Should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Popover cut off (off screen).
3 participants